-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent sending ETW within a lock #1146
Conversation
This code amplifies overhead of ETW tracing into thread pool issues, and increases noise in perf tests.
Could this end up with events appearing in incorrect order via ETW, and would that be an issue? |
it looks like the optProf data is out of dated in this repo. Maybe OptProf run stops working in this repo? I will rerun it to see whether it can be resolved. @AArnott |
@lifengl, this repo had been having optprof run problems recently, but I fixed them recently, and we've had a few insertions in the last week. |
it somehow blocks this PR to be merged. Maybe this one is created earlier so builds in 17.6 are not excluded? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This code amplifies ETW trace costs, and makes them into thread pool issues in some traces which leads to more noises in performance tests.