Fix hang in AsyncLazy<T>.DisposeValueAsync
#1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method was failing to create a JoinableTask dependency link such that a value factory that was already in progress and required the main thread would be able to get it from the `DisposeValueAsync` caller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was failing to create a JoinableTask dependency link such that a value factory that was already in progress and required the main thread would be able to get it from the
DisposeValueAsynccaller.Fixes devdiv-2169193
For the record, this fixes a bug that existed since the introduction of this method in 17.8. So while this PR fixes 17.12, I based the fixing commit in the 17.8 version so we can merge the fix into any older release if necessary.