-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix, update, and enable long running tests #4209
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hossam-nasr
changed the title
Fix and enable long running tests
Fix, update, and enable long running tests
Jul 10, 2024
nturinski
reviewed
Jul 11, 2024
nturinski
approved these changes
Jul 16, 2024
alexweininger
approved these changes
Jul 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables long running tests and fixes all the tests to our testing suite so that all our tests, including E2E and long running tests, finally pass :) Java and Ballerina long running tests have been disabled, pending installing Java/Ballerina on the new pipeline images, tracked here: #4210. PR changes include:
Removing deprecated/obsolete tests, including:
Adding tests for new language versions, including:
Removing extra prompts and adding necessary ones, such as removing prompts for subscriptions that aren't needed or adding prompts for language model versions
Re-enabling Python and C# create and deploy tests on Windows (which is actually the only agent running right now on the new pipelines)
Removing
package-lock.json
and runningnpm install
again to update thepackage-lock
file, in order to, among other upgrades, upgrade thechokidar
package to3.6.0
, to avoid running into this issue which was causing the TypeScript create and deploy test to fail: Incompatibility of types with recent changes in@types/node
paulmillr/chokidar#1299