dev: Add ddsignfiles wrapper #1774
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexweininger
force-pushed
the
alex/ddsignfiles
branch
from
f00a161
to
5648a20
Compare
|
Docker and several others do not use the dev package. Can we put this in the pipelines instead? |
Rats. The pipelines folder isn't currently published as a package. Do you know if I include this script in the pipelines folder if it will be accessible within a pipeline run that depends on the templates? I'll try it out. |
|
I'm starting to think it might just be easier to use MSBuild and write a csproj file into each repo 😢. Let me try that out too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file is a wrapper around the DDSignFiles.dll tool that is present in pipelines that have signing setup and enabled. It has been copied from source because it's easier than consuming an npm package. We can use this js helper to sign files with a js script in each extension instead of requiring a .csproj and building it with MSBuild. I think I'd rather stay in the nodejs world if we can.