Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-pipelines: Add steps to sign extensions with MSBuild #1775

Merged
merged 50 commits into from
Aug 26, 2024

Conversation

alexweininger
Copy link
Member

@alexweininger alexweininger commented Aug 23, 2024

After discussions with the team, the CI/CD design we're going for is: two pipelines 1. Build and 2. Release. Build will build/package/test AND sign. And upload the signed bits. Release will just download the bits, and release it using vsce.

In this PR:

  1. Move from the 1ES template to the MicroBuild template. They are basically the same so there were little breaking changes.
  2. Enable the signing toolset which is auto installed thanks to the new MicroBuild template
  3. Add a new sign template that uses vsce to generate a manifest (the file that is used for signing)
  4. Use MSBuild to sign the extensions

The changes in the pipelines will look for a ".azure-pipelines/SignExtension.signproj" file in the repo and will sign the extension if present. I will be adding this and the below change to each extension.

Template consumers will have to add the following to their 1esmain.yml. This is required by the MicroBuild template that we are now using. I can't figure out a way to avoid this.

variables:
  # Required by MicroBuild template
  - name: TeamName
    value: "Azure Tools for VS Code"

See microsoft/vscode-azureresourcegroups#907 for what these changes will look like.

@alexweininger
Copy link
Member Author

I'm going to wait to merge this until most (if not all) the consumers are ready. I'm pretty sure I have all the PRs made.

@alexweininger alexweininger merged commit d3c4079 into main Aug 26, 2024
4 checks passed
@alexweininger alexweininger deleted the alex/sign-with-msbuild branch August 26, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants