Fix for Github issue 587: duplicate project structure causes error #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DirectoryNodes use PREFIX/subdir
|
|
bobbrow
approved these changes
Apr 14, 2020
There was a problem hiding this comment.
I didn't fully understand your comment on #587. Is there still a bug that this PR doesn't address? I tried the example you posted in the comment as well as the repo you linked in this PR and didn't see a problem with either of them.
|
i updated the code in the reproduction repository. project(base2) was supposed to be commented out.
Additional explanation:
But i found the issue. |
bobbrow
approved these changes
Apr 16, 2020
|
Thank you so much! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves: #587
Changes
Added project sourceDirectory to class ProjectNode.
_rootDir is now initialized with sourceDirectory as prefix.
Added projectDirectory to tooltip of ProjectNodes
Notes
Minimal project to reproduce issue:
https://github.com/SchweizS/vscode-cmake-tools587