Fixes vs2010 doesn't recognize host=x64 #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreeis
reviewed
Oct 13, 2020
| if (generatorName) { | ||
| log.debug(` ${localize('generator.present', 'Generator Present: {0}', generatorName)}`); | ||
| kit.preferredGenerator = { | ||
| name: generatorName, | ||
| platform: generatorPlatformFromVSArch[targetArch] as string || targetArch, | ||
| // CMake generator toolsets support also different versions (via -T version=). | ||
| toolset: "host=" + hostArch | ||
| toolset | ||
| }; | ||
| } | ||
| log.debug(` ${localize('selected.preferred.generator.name', 'Selected Preferred Generator Name: {0} {1}', generatorName, JSON.stringify(kit.preferredGenerator))}`); |
There was a problem hiding this comment.
How about we assign toolset as:
toolset: "host=" + kitHostTargetArch(hostArch, targetArch, majorVersion < 15)
There was a problem hiding this comment.
Great. Can you test that in your setup and if all is well commit an update? I'll approve it.
There was a problem hiding this comment.
toolset: "host=" + kitHostTargetArch(hostArch, targetArch, majorVersion < 15)
Why host= still here? that's should be removed
There was a problem hiding this comment.
[main] 正在配置文件夹: xemu-with-lib
[driver] 删除 e:/CI-Cor-Ready/xemu/xemu-with-lib/build-cmake/msvc_10_0_win32_x64_Debug/CMakeCache.txt
[driver] 删除 e:\CI-Cor-Ready\xemu\xemu-with-lib\build-cmake\msvc_10_0_win32_x64_Debug\CMakeFiles
[proc] 执行命令: "C:\Program Files\CMake\bin\cmake.EXE" --no-warn-unused-cli -DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=TRUE -He:/CI-Cor-Ready/xemu/xemu-with-lib -Be:/CI-Cor-Ready/xemu/xemu-with-lib/build-cmake/msvc_10_0_win32_x64_Debug -G "Visual Studio 10 2010" -T host=amd64 -A x64
[cmake] Not searching for unused variables given on the command line.
[cmake] CMake Error at CMakeLists.txt:17 (project):
[cmake] Generator
[cmake]
[cmake] Visual Studio 10 2010
[cmake]
[cmake] given toolset specification
[cmake]
[cmake] host=amd64
[cmake]
[cmake] that contains invalid field 'host=amd64'.
[cmake]
[cmake]
[cmake] -- Configuring incomplete, errors occurred!
[cmake] See also "E:/CI-Cor-Ready/xemu/xemu-with-lib/build-cmake/msvc_10_0_win32_x64_Debug/CMakeFiles/CMakeOutput.log".
There was a problem hiding this comment.
Oh, I thought that the problem was using amd64 versus x64, not the host attribute itself. I see now, looks good. I am approving.
2010 doesn't have x64 host compiler.
andreeis
approved these changes
Oct 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses item #[[put issue number here to generate a link]]
This changes [[visible behavior/performance/documentation/etc.]]
The following changes are proposed:
The purpose of this change
Other Notes/Information