Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using consistence function for environment set and get to fix the gap between windows and unix. #1763

Closed
wants to merge 3 commits into from
Closed

Using consistence function for environment set and get to fix the gap between windows and unix. #1763

wants to merge 3 commits into from

Commits on Jul 27, 2021

  1. Convert all src process.env access to util.envGetValue

    @lygstate
    lygstate committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    ad06918 View commit details
    Browse the repository at this point in the history

  2. Convert collectDevBatVars to use util.envGetValue

    @lygstate
    lygstate committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    189ff99 View commit details
    Browse the repository at this point in the history

  3. Using consistence function for environment set and get to fix the 

    gap between windows and unix.

Directly use configureEnv, as now getConfigureEnvironment would not return environment with undefined/null value

Also expand with environment variable when get effectiveKitEnvironment

Fixes microsoft#1592

preset using the same environment variable merge strategy like kits does

Using GeneralEnvironmentType

Signed-off-by: Yonggang Luo <[email protected]>
    @lygstate
    lygstate committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    a4dec6a View commit details
    Browse the repository at this point in the history