Patch Windows SDK bin path in a more reliable way. #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lygstate
force-pushed
the
windows-sdk-path-patch
branch
from
ae75320
to
d59a012
Compare
bobbrow
reviewed
Jul 27, 2021
lygstate
force-pushed
the
windows-sdk-path-patch
branch
from
d59a012
to
bfd62fd
Compare
|
@bobbrow Hi, this is a relative small fix, can this be merged in 1.8.x? |
|
Sorry we didn't take a look at this yet. We generally reserve the '.x' patches to fix regressions from the major release and I've been shorthanded for the past few weeks so we think to pull in any of the 1.9.0 stuff. One consolation is that we plan to have a shorter 1.9 cycle (~1 month) compared to our normal release cycle (~3 months) because of the CMakePresets v3 addition. |
lygstate
force-pushed
the
windows-sdk-path-patch
branch
from
bfd62fd
to
b66956f
Compare
Signed-off-by: Yonggang Luo <[email protected]>
lygstate
force-pushed
the
windows-sdk-path-patch
branch
from
b66956f
to
567fdb6
Compare
andreeis
approved these changes
Oct 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve of #1955