Add missing environment variables to MSVC_ENVIRONMENT_VARIABLE #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ABLES so they get forwarded correctly. Fixes CMake and Clang detecting wrong MSVC toolkit version, paths etc. Fixes microsoft#1053
bobbrow
requested changes
Aug 30, 2021
… future users to know the context of it's removal
bobbrow
reviewed
Sep 3, 2021
src/kit.ts
Outdated
| @@ -603,13 +603,19 @@ const MSVC_ENVIRONMENT_VARIABLES = [ | |||
| 'LIBPATH', | |||
| 'NETFXSDKDir', | |||
| 'Path', | |||
| //'Platform', - disabled at the request of @bobbrow as this causes some of MS internal projects to fail to build | |||
There was a problem hiding this comment.
We don't normally annotate our code with direct references to team members. I think it is sufficient to say that it is disabled because it is currently unnecessary and causes some projects to fail to build.
There was a problem hiding this comment.
Changed as requested.
… future users to know the context of it's removal
bobbrow
approved these changes
Sep 3, 2021
|
Not sure why the tests seem to have failed ( |
|
'C++ extension not installed' is not an error. I saw some flakiness on one of the test platforms recently. We need to investigate that. |
|
Yeah, seems to have passed now! |
This was referenced Sep 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses item #1053
This changes visible behavior
The following changes are proposed:
The purpose of this change
This also fixes Clang's ability to find the MSVC toolkit correctly as noted in my comment on the issue