Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update flow for missing CMakeLists.txt #888

Merged
merged 6 commits into from
Nov 11, 2019
Merged

Conversation

bobbrow
Copy link
Member

@bobbrow bobbrow commented Nov 8, 2019

This change addresses item #533

This changes visible behavior

The following changes are proposed:

When CMakeLists.txt is not discovered in the root of the folder, give the user the open to open settings and update the cmake.sourceDirectory setting

@bobbrow bobbrow merged commit 935e519 into develop Nov 11, 2019
@bobbrow bobbrow deleted the bobbrow/noCMakeLists branch November 11, 2019 19:59
@Zingam
Copy link
Contributor

Zingam commented Nov 18, 2019

@bobbrow This a very useful feature:

When CMakeLists.txt is not discovered in the root of the folder, give the user the open to open settings and update the cmake.sourceDirectory setting

Yet I had to close and re-open the folder for the newly set path to CMakeLists.txt to be detected by the extension. Is this expected? Clicking on the Configure on the left CMake pane would pop up the error message again and again before reloading the project.

@bobbrow
Copy link
Member Author

bobbrow commented Nov 18, 2019

No, that's not expected. It worked for me, but I just tried another case today and I saw the behavior your described. I'm not sure why.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants