Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook icon: Run in Section #238

Open
Yoyokrazy opened this issue Mar 11, 2024 · 3 comments
Open

Notebook icon: Run in Section #238

Yoyokrazy opened this issue Mar 11, 2024 · 3 comments
Assignees

Comments

@Yoyokrazy
Copy link

Is your icon request related to a problem? Please describe.

  • We are introducing new functionality to notebooks for Run Cells in Section, and Fold Section. This will come with a toolbar in the outline view, allowing users to execute and fold cells from that view pane.

Describe the solution you'd like

  • A new icon for Run in Section, clearly distinguishing it from "Execute cell and below" and "Execute Cell and dependencies".

Describe alternatives you've considered

  • Not rendering an icon as the primary action, and keeping both actions in the secondary overflow menu (decreasing discoverability, though there will still be the dots showing up which users haven't seen before)

Additional context
Picture of outline view in a notebook. The markdown header is focused with the primary action Run Cells in Section, and secondary action Fold Section. The outline entry for the code cell is being hovered over.
image

Hover description:
image

Execute Cell and Below:
image

Run with Dependencies codicon:
image

Potential thought for new icon. In my mind, sections/groupings are often designated with indentation, and they are in the outline pane specifically.
image

@hbons
Copy link
Member

hbons commented Mar 20, 2024

For folding we have map and map-filled:

image

I'm also adding a rotated version for cases where that makes more conceptual sense.

@hbons
Copy link
Member

hbons commented Mar 20, 2024

Instead of introducing a new concept, how about using the run-all icon? This makes in the group headers of the Outline view. Is this the only place the action will appear?
image

@daviddossett
Copy link
Contributor

At a glance, I think the vanilla run icon is actually fine here since it's placed on the section header. Not sure a variant will really move the needle. We could try that first and see if it needs a more specific icon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants