Add new map-vertical and map-vertical-filled icons #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaeumer
approved these changes
Mar 20, 2024
|
What are these for? I think the original map icon is intended for source maps or something. @connor4312 would know. |
|
Source maps use the compass icon |
|
Ah, my bad. Hallucinating :D |
|
Notebooks wants it, and the diff viewer uses it to toggle unchanged lines: 
I thought it would be good to have a vertical version as it matches the direction. :) |
|
@daviddossett we might want to use GitHub style collapse/expand icons in the future: |
|
That notebooks issue links to the run-in-section issue. Is that intended? Not sure how it relates to the regions toggle above. Agreed that the map icon doesn't convey the command very well though. I think something like the GH example would make more sense. |
|
seems we have these already: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vertical variants of the map icon:
map-verticalandmap-vertical-filled.Also add
fold-*mappings andmap-horizontal-*mappings to the originalmapfor consistency.Related: #238