-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support yarn pnp for nodeAddonIncludes #7123
Conversation
1330360
to
6855ddb
Compare
This solves problems with Yarn PnP and node addon includes.
Thanks for the contribution. We'll try to review this later this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stdout I get from yarn is
'yarn node v1.19.1\n"<workspaceFolder>\node_modules\\node-addon-api"\nDone in 0.51s.'
which isn't processed correctly because the code just expects the middle line. Is that supposed to work correctly and/or how are you getting it to work?
This is normal, because it's for Yarn Berry. |
Ah, thanks. I'll look into that tomorrow. |
This solves problems with Yarn PnP and node addon includes.
✅ Works correctly.