Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comment continuation. #7238

Merged
merged 4 commits into from
Mar 31, 2021
Merged

Fix comment continuation. #7238

merged 4 commits into from
Mar 31, 2021

Conversation

sean-mcmanus
Copy link
Collaborator

Follow up to #5733

@sean-mcmanus sean-mcmanus requested review from elahehrashedi and a team March 26, 2021 14:00
@sean-mcmanus sean-mcmanus mentioned this pull request Mar 26, 2021
Closed
@sean-mcmanus
Copy link
Collaborator Author

@elahehrashedi Do you know if there was a reason for the \\A? That matches the letter A. Was it just a typo or was something else intended?

@sean-mcmanus sean-mcmanus reopened this Mar 26, 2021
@elahehrashedi
Copy link
Contributor

elahehrashedi commented Mar 31, 2021 •
edited
Loading

This change will break this scenario, but we agreed that the current scenario is more common.
3

@sean-mcmanus sean-mcmanus merged commit db7c9c7 into main Mar 31, 2021
@sean-mcmanus sean-mcmanus deleted the seanmcm/fixCommentContinuation branch March 31, 2021 17:27
@HO-COOH HO-COOH mentioned this pull request Apr 4, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bobbrow bobbrow bobbrow left review comments

@elahehrashedi elahehrashedi elahehrashedi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sean-mcmanus @elahehrashedi @bobbrow