Replace non-ASCII punctuation (broke syntax before) #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain CSS snippets were broken due to using unicode special characters, specifically the `unicode-range` property of the `@font-face` at-rule. The schema had some inconsistencies in using special characters and regular ASCII, so I replaced those instances with their respective ASCII counterparts. - Replace U+201C/201D (“ and ”) with U+0022 (quotation mark ") - Replace U+2018/2019 (left/right single quotation marks ‘ ’) with U+0027 (apostrophe ') - Replace U+2013 (en dash –) with U+002D (hyphen-minus -)
|
@microsoft-github-policy-service agree |
|
any maintainers want to check this? @aeschli |
sandy081
previously approved these changes
Oct 13, 2022
|
Resolved the merge conflict (wasn't much to do), can I get another review? |
|
Gonna mention since this might get lost in notification hell otherwise @sandy081 |
aeschli
approved these changes
Oct 14, 2022
sandy081
approved these changes
Oct 14, 2022
|
Thanks @addiment! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain CSS snippets were broken due to using unicode special characters, specifically the
unicode-rangeproperty of the@font-faceat-rule. The schema had some inconsistencies in using special characters and regular ASCII, so I replaced those instances with their respective ASCII counterparts.“”) with U+0022 (quotation mark")‘’) with U+0027 (apostrophe')–) with U+002D (hyphen-minus-)While the ASCII swap on quotation marks and parenthesis is mostly preference, the unicode hyphens don't work when used in the browser, which I believe warrants the change. From the W3C CSS fonts specification:
4.5. Character range: the 'unicode-range' descriptor
7.1. The <urange> type