Added Components Metadata #161 #186

sk593 · 2021-06-21T18:46:24Z

Added component metadata (name of component) to the application tree view. this addresses one aspect of issue #161 and addresses #167 that requests to expose more metadata. An example of the components view is shown below

philliphoff · 2021-06-21T22:02:56Z

@sk593 Can you add a screenshot showing the new UX; that often helps with reviews.

src/services/daprClient.ts

src/views/applications/daprComponentsNode.ts

src/views/applications/daprMetaDataNode.ts

src/views/applications/daprComponentsNode.ts

… types

sk593 · 2021-06-23T16:10:36Z

I initially pushed changes to address the comments but it caused some Linux package checks to fail. I accidentally uncommitted those changes when trying to fix the error so the original PR doesn't have the initial commits I made. But the last commit should have all the original changes, as well as the requested updates @philliphoff

src/views/applications/daprApplicationNode.ts

src/views/applications/daprMetadataNode.ts

src/views/applications/daprComponentsNode.ts

philliphoff · 2021-06-25T17:04:00Z

src/views/applications/daprComponentsNode.ts



 export default class DaprComponentsNode implements TreeNode {
-    constructor(public readonly metadata: string, public readonly application: DaprApplication) {
+    constructor(public readonly application: DaprApplication, public readonly daprClient: DaprClient) {


Nit: unless they have to be accessible outside of the class, use private readonly.

philliphoff · 2021-06-25T17:04:40Z

src/views/applications/daprComponentsNode.ts

+        if(components.length > 0) {
+            return components.map(comp => new DaprMetadataNode(comp.name, 'database'));
+        }
+        return [new DaprMetadataNode(label, 'warning')];
    }

    private async getMetadata(application: DaprApplication, token?: vscode.CancellationToken | undefined): Promise<DaprMetadata>  {


Nit: as this is now only a single line function, used from a single location, is it necessary?

philliphoff · 2021-06-25T17:09:59Z

src/views/applications/daprMetadataNode.ts

@@ -5,15 +5,15 @@ import * as vscode from 'vscode';
 import TreeNode from "../treeNode";

 export default class DaprMetadataNode implements TreeNode {
-    constructor(public readonly metadata: string) {
+    constructor(public readonly metadata: string, public readonly icon: string) {


Perhaps themeIconId: string to reinforce its usage (as opposed to a resource path string, which is another way to specify an icon)?

philliphoff · 2021-06-25T17:12:24Z

@sk593 A couple of final nits, but otherwise looks good. Let's also make sure there is an issue filed (maybe assigned to @AaronCrawfis) to get a better set of icons into the product at some point.

src/views/applications/daprComponentsNode.ts