Start Dapr dashboard using random port #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the extension started the Dapr dashboard using a random port it derives on its own. This change switches to a new feature in Dapr 1.10 where the Dapr CLI itself determines a suitable port. Also added is an attempt to actually shutdown the dashboard when the VS Code session is closed (i.e. when the extension is deactivated) by killing the process tree of the dashboard. (If this fails, the dashboard will still be shutdown when VS Code as a whole exits.)
This required way more refactoring of the
Processwrapper than I would have expected, as well as the addition of an "async disposable" type. (Cancellation tokens weren't enough as killing the process tree is async, and VS Code wasn't giving enough time for it to happen implicitly.)Resolves #277