-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review snippets guide / sample #2187
Comments
I have removed the advertisement because that doesn't belong in a technical guide. Then I think that the whole guide as zero meat and it took me a really long time understand what the goal is. Makes me question what the guides are about? Is the goal to explain every single contribution point? How does this compare to Extension Guides? |
@jrieken I was thinking maybe we should add pointers to successful usages of a pattern. For example, TreeView doc could say: "GitLens and GitHub PR extensions are two extensions that use this extension API". Are you opposed to including any such pointers in the API doc? I agree this guide currently does not have much meat. It's
Yes, these three sections take care of
Languages support is a large area of our API so I extracted it out into its own section. Otherwise I end up with a gigantic Extension Guides section. |
Maybe as appendix for further reading, surely not atop as the first thing to see and I am also not a fan of the tiles as they grab too much attention. |
Sounds good. I'll close this one then. I did point to other extensions in the Extending Workbench topic. Feel free to open new issues if you don't like that either: https://vscode-ext-docs.azurewebsites.net/api/extension-capabilities/extending-workbench |
The source of doc is at https://github.com/Microsoft/vscode-docs/blob/ext-docs/api/language-extensions/snippet-guide.md
Please review this guide / sample combo. Edit as you fit, and add things you think are missing.
The text was updated successfully, but these errors were encountered: