Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing a byte and saving (in a virtual workspace?) always triggers a warning from hex editor extension #321

Closed
joyceerhl opened this issue Nov 30, 2021 · 0 comments
Closed

Editing a byte and saving (in a virtual workspace?) always triggers a warning from hex editor extension #321

joyceerhl opened this issue Nov 30, 2021 · 0 comments
Assignees
@connor4312 @lramos15

Comments

@joyceerhl
Copy link

Testing microsoft/vscode#138092

Edit a byte in https://github.com/corkami/pocs/blob/befb3632214640a4af20be3b463f41e4b82f04f6/images/jpg/20scans.jpg in RemoteHub on desktop and hit save. On each save the hex editor extension always displays this warning
image

Not sure if this is a RemoteHub bug? Since the hex editor is just using VS Code file system APIs I would expect your writeFile calls to do the right thing.

overwrite.mp4
connor4312 added a commit that referenced this issue Dec 15, 2021
@connor4312
fix: tweak behavior around dirty file detection
f0b0622 
Fixes #321
@connor4312 connor4312 mentioned this issue Dec 15, 2021
Merged
lramos15 pushed a commit that referenced this issue Dec 16, 2021
@connor4312
Streaming 1 fixes (#325)
94f52a1 
* feat: add large file support

For #313

* fix: shift click in hex editor

For #320

* fix: avoid locking file descriptors of natively opened files

* fix: tweak behavior around dirty file detection

Fixes #321

* feat: allow enter to replace and navigate

For #322

* fix: scrolling with non-zero starts being wrong

For #319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connor4312 connor4312

@lramos15 lramos15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@connor4312 @lramos15 @joyceerhl