Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure full input outline is visible #248

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Ensure full input outline is visible #248

merged 2 commits into from
Mar 17, 2021

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Mar 17, 2021

Fixes #231

Not sure what the history of that style is.

recording (10)

@Tyriar Tyriar added this to the March 2021 milestone Mar 17, 2021
@Tyriar Tyriar requested a review from lramos15 March 17, 2021 14:45
@Tyriar Tyriar self-assigned this Mar 17, 2021
lramos15
lramos15 approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@lramos15 lramos15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was there because there would occasionally be huge gaps between the data inspector cells depending on your screens DPI. We can take it away for now and see if the data inspector moving to the panel fixed itself.

@Tyriar
Copy link
Member Author

Tyriar commented Mar 17, 2021

Ah ok, that seems to be fine when zooming in and out. I was also going to look into the layout shifting around due to the unicode chars too if that's still a thing.

@Tyriar Tyriar merged commit 5744000 into main Mar 17, 2021
@Tyriar Tyriar deleted the tyriar/outline_visibility branch March 17, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lramos15 lramos15 lramos15 approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
March 2021
Development

Successfully merging this pull request may close these issues.

Data inspector text boxes lack bottom focus outline
2 participants
@Tyriar @lramos15