Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: get a 45% performance boost #399

Merged
merged 1 commit into from
Dec 12, 2022
Merged

refactor: get a 45% performance boost #399

merged 1 commit into from
Dec 12, 2022

Commits on Dec 10, 2022

  1. refactor: get a 45% performance boost

    This moves data retrieval from data rows into data pages. I noticed a
    bunch of time was spent negotiating data retrieval inside each
    `<DataRowContents />`, so this improves that by making it happen in one
    (or, if the user is on a boundary, two) places instead of 30+. This net
    about a 30% boost over the original 'new page' render time.
    
    I also moved the DOM structure to be based on DataPages that are in
    layers and moved as a group instead of inidivudally. This net an
    additional 15% improvement over the original 'new page' time.
    
    Cost to render a new page before:
    
    ![](https://memes.peet.io/img/22-12-6eab495d-1008-4eee-a9e5-eb90233b723e.png)
    
    after:
    
    ![](https://memes.peet.io/img/22-12-0df37399-2450-4631-9b25-e3fb91dccb9c.png)
    connor4312 committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    109e09c View commit details
    Browse the repository at this point in the history