fix: improve range selection logic, support delete #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was a long time on my todo to fix the "publishSelections", as it was previously linear time with the _number of bytes_ selected -- not the best. Once I fixed that, supporting deletions was fairly trivial, although it is handled a little differently than other edits... Closes #466
TylerLeonhardt
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was a long time on my todo to fix the "publishSelections", as it was
previously linear time with the number of bytes selected -- not the best.
Once I fixed that, supporting deletions was fairly trivial, although it
is handled a little differently than other edits...
Closes #466