Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hover byte status #502

Merged
merged 5 commits into from
Apr 2, 2024
Merged

Add hover byte status #502

merged 5 commits into from
Apr 2, 2024

Conversation

tomilho
Copy link
Contributor

@tomilho tomilho commented Mar 27, 2024

Adds Hover: 0/0x00 to the left of the selectionCount state. I labeled it with Hover: to easily distinguish from the selectionCount state.
Closes #467

hover

@connor4312
Copy link
Member

Thanks for the PR! Instead of the current display, I think we should make the primary badge the hover state and show the selected in parenthesis similar to what is done for text editors:

image

So in the case:

  • Selection but no hover: just show 0x456 selected
  • Hover but no selection: 0x123
  • Both: 0x123 (0x456 selected)

@tomilho
Copy link
Contributor Author

tomilho commented Mar 30, 2024

Thank you for the feedback. Just to double check I completely understand, we would have 2 badges:

  • In the primary badge, the hover state and the selected.
  • In the secondary badge, the focused state.

e.g)

  • Primary badge only: 0x123 (0x456 selected) or 0x123 or 0x456 selected
  • Secondary badge only: 0x789
  • Together: 0x123 (0x456 selected) 0x789 or 0x123 0x789 or 0x456 selected 0x789

@tomilho
Copy link
Contributor Author

tomilho commented Apr 1, 2024

Here's visually what I was attempting to describe per the most recent commit:
hover2

@connor4312
Copy link
Member

Looks great, thanks! Seems like we have a build pipeline issue right now but I'll that fixed and this merged in a day or two

@tomilho
Copy link
Contributor Author

tomilho commented Apr 1, 2024

Thank you! 😀

@connor4312 connor4312 merged commit f151c53 into microsoft:main Apr 2, 2024
5 checks passed
@tomilho tomilho deleted the fr-hover branch April 3, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]Show the memory address of a cell when hovering up with mouse
4 participants