Get context help working and fixup path problems with kernel tree #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
commented
Apr 22, 2022
| @@ -204,7 +204,7 @@ export function getDisplayNameOrNameOfKernelConnection(kernelConnection: KernelC | |||
| const envName = | |||
| kernelConnection.interpreter.envName || | |||
| (kernelConnection.interpreter.envPath | |||
| ? path.basename(kernelConnection.interpreter.envPath) | |||
| ? path.basename(kernelConnection.interpreter.envPath.fsPath) | |||
IanMatthewHuff
approved these changes
Apr 22, 2022
|
Not sure how webviews works locally, but I think I fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in the contextual help stuff.
Also fixed up some PythonEnvironment URI changes (jupyter changed to use URIs for stuff) (Kernel tab was broken)
Changed to webpack because of stuff like this: evanw/esbuild#1619
ESBuild is a lot pickier about what it will consume. Instead of trying to resolve those problems (I had about 10 of them), just switched to webpack.