telemetry for cound of open IWs (#13282)

* telemetry for cound of open IWs * generate telemetry
microsoft · Apr 5, 2023 · 7e214aa · 7e214aa
1 parent 680b2e0
commit 7e214aa
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 12 deletions.
diff --git a/src/gdpr.ts b/src/gdpr.ts
@@ -1137,6 +1137,7 @@
      "hasOwner": {"classification":"SystemMetaData","purpose":"FeatureInsight","comment":"If the window was created for a text file","owner":"amunger"},
      "mode": {"classification":"SystemMetaData","purpose":"FeatureInsight","comment":"Creation mode: multiple, perfile or single","owner":"amunger"},
      "restored": {"classification":"SystemMetaData","purpose":"FeatureInsight","comment":"Was the window restored from a previous session","owner":"amunger"},
+     "windowCount": {"classification":"SystemMetaData","purpose":"FeatureInsight","comment":"Number of active interactive windows the user has open","owner":"amunger","isMeasurement":true},
      "${include}": [
        "${F1}"
 

diff --git a/src/interactive-window/interactiveWindowProvider.ts b/src/interactive-window/interactiveWindowProvider.ts
@@ -130,13 +130,18 @@ export class InteractiveWindowProvider
                 tab,
                 Uri.parse(iw.inputBoxUriString)
             );
-            sendTelemetryEvent(Telemetry.CreateInteractiveWindow, undefined, {
-                hasKernel: false,
-                hasOwner: !!iw.owner,
-                mode: mode,
-                restored: true
-            });
+
             this._windows.push(result);
+            sendTelemetryEvent(
+                Telemetry.CreateInteractiveWindow,
+                { windowCount: this._windows.length },
+                {
+                    hasKernel: false,
+                    hasOwner: !!iw.owner,
+                    mode: mode,
+                    restored: true
+                }
+            );
 
             const handler = result.closed(this.onInteractiveWindowClosed.bind(this, result));
             this.disposables.push(result);
@@ -219,13 +224,17 @@ export class InteractiveWindowProvider
                 editor,
                 inputUri
             );
-            sendTelemetryEvent(Telemetry.CreateInteractiveWindow, undefined, {
-                hasKernel: !!initialController,
-                hasOwner: !!resource,
-                mode: mode,
-                restored: false
-            });
             this._windows.push(result);
+            sendTelemetryEvent(
+                Telemetry.CreateInteractiveWindow,
+                { windowCount: this._windows.length },
+                {
+                    hasKernel: !!initialController,
+                    hasOwner: !!resource,
+                    mode: mode,
+                    restored: false
+                }
+            );
             this._updateWindowCache();
 
             // This is the last interactive window at the moment (as we're about to create it)

diff --git a/src/telemetry.ts b/src/telemetry.ts
@@ -2301,6 +2301,7 @@ export class IEventNamePropertyMapping {
         hasOwner: boolean;
         mode: string;
         restored: boolean;
+        windowCount: number;
     }> = {
         owner: 'amunger',
         feature: ['InteractiveWindow'],
@@ -2326,6 +2327,14 @@ export class IEventNamePropertyMapping {
                 purpose: 'FeatureInsight',
                 comment: 'Was the window restored from a previous session'
             }
+        },
+        measures: {
+            windowCount: {
+                classification: 'SystemMetaData',
+                purpose: 'FeatureInsight',
+                comment: 'Number of active interactive windows the user has open',
+                isMeasurement: true
+            }
         }
     };
     /**