Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with [email protected] and overrides #11013

Closed
DonJayamanne opened this issue Aug 2, 2022 · 0 comments · Fixed by #11025
Closed

Problems with [email protected] and overrides #11013

DonJayamanne opened this issue Aug 2, 2022 · 0 comments · Fixed by #11025
Assignees
Labels
debt Code quality issues

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Aug 2, 2022

Problem: Currently we're unable to pin certain packages to specific versions due to a bug in the version of npm used

We rely on overrides section in package.json to pin specific packages to particular versions

Solutions

  • Enforce node and npm/yarn versions in package.json
    • i think it's over kill, but this prevents generation of lock files that are not reproducible (we have such lock files today)
  • Option 1: Use yarn
  • Option 2: Update npm to the latest version
    • Clearly document the version of node and npm required
      If a package is manually and entry added into package.json, then we should document this in package.json
      E.g. add a section, this won't be necessary if we use yarn or if we use the latest version of npm
    "depedencies-manually-added": {
        "added-to-fix-dependabot-issues": ["<package>:<version>"]
    }
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug debt Code quality issues labels Aug 2, 2022
@DonJayamanne DonJayamanne self-assigned this Aug 2, 2022
@DonJayamanne DonJayamanne removed the bug Issue identified by VS Code Team member as probable bug label Aug 2, 2022
@github-actions github-actions bot added the triage-needed Issue needs to be triaged label Aug 2, 2022
@DonJayamanne DonJayamanne added discuss-at-standup and removed triage-needed Issue needs to be triaged labels Aug 2, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant