Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages and npm version #11025

Merged
merged 3 commits into from
Aug 2, 2022
Merged

Update packages and npm version #11025

merged 3 commits into from
Aug 2, 2022

Conversation

DonJayamanne
Copy link
Contributor

@DonJayamanne DonJayamanne commented Aug 2, 2022

Fixes #11013

@DonJayamanne DonJayamanne requested a review from a team as a code owner August 2, 2022 20:01
"fs-path": "0.0.25",
"simple-get@<3.1.1": "3.1.1",
"validator@<13.7.0": "13.7.0",
"jpeg-js@<0.4.4": "0.4.4",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using @< so that any package that depends on a later version will still get the later version instead of what we specific here.
I.e. we need to ensure we pin only to a specific version unless absolutely necessary.

@@ -14,7 +14,7 @@
### Prerequisites

1. [Node.js](https://nodejs.org/) 16.14.2
2. [npm](https://www.npmjs.com/) 8.3.0
2. [npm](https://www.npmjs.com/) 8.15.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Older versions are buggy

@@ -2493,8 +2493,15 @@
"fsevents": "^2.3.2"
},
"overrides": {
"simple-get": "3.1.1",
"fs-path": "0.0.25",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fs-path is not used anywhere, hence this isn't required.

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2022

Codecov Report

Merging #11025 (d2d20ff) into main (fdc48e0) will decrease coverage by 0%.
The diff coverage is n/a.

❗ Current head d2d20ff differs from pull request most recent head 0a8223e. Consider uploading reports for the commit 0a8223e to get more accurate results

@@           Coverage Diff           @@
##            main   #11025    +/-   ##
=======================================
- Coverage     63%      62%    -1%     
=======================================
  Files        482      482            
  Lines      33819    33819            
  Branches    5510     5510            
=======================================
- Hits       21353    21137   -216     
- Misses     10430    10601   +171     
- Partials    2036     2081    +45     
Impacted Files Coverage Δ
...ernels/jupyter/session/requestAgentCreator.node.ts 60% <0%> (-40%) ⬇️
.../notebooks/controllers/controllerDefaultService.ts 40% <0%> (-26%) ⬇️
...nels/jupyter/jupyterRemoteCachedKernelValidator.ts 28% <0%> (-25%) ⬇️
...ernels/jupyter/launcher/jupyterNotebookProvider.ts 84% <0%> (-16%) ⬇️
src/platform/common/crypto.ts 50% <0%> (-15%) ⬇️
...tension-side/variablesView/variableViewProvider.ts 81% <0%> (-14%) ⬇️
...c/kernels/jupyter/session/jupyterSessionManager.ts 49% <0%> (-14%) ⬇️
...rc/notebooks/controllers/controllerRegistration.ts 75% <0%> (-12%) ⬇️
src/kernels/jupyter/remoteKernelFinder.ts 76% <0%> (-12%) ⬇️
...kernels/jupyter/launcher/notebookServerProvider.ts 65% <0%> (-11%) ⬇️
... and 37 more

@DonJayamanne DonJayamanne merged commit 60c39f2 into main Aug 2, 2022
@DonJayamanne DonJayamanne deleted the updatePackages branch August 2, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with [email protected] and overrides
4 participants