Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Create Environment"- pressing esc shows the kernel picker again #12240

Closed
roblourens opened this issue Nov 30, 2022 · 6 comments
Closed

"Create Environment"- pressing esc shows the kernel picker again #12240

roblourens opened this issue Nov 30, 2022 · 6 comments
Assignees
@rebornix @DonJayamanne
Labels
bug Issue identified by VS Code Team member as probable bug notebook-kernel Kernels issues (start/restart/switch/execution, install ipykernel) notebook-kernel-picker upstream-python Blocked on upstream Python Ext verified Verification succeeded

Comments

@roblourens
Copy link
Member

Testing #11963

  • Open kernel picker
  • "Create Environment"
  • Press escape

The kernel source picker is shown again. Pressing esc should hide the current picker and not show another one.
@DonJayamanne
Copy link
Contributor

Upstream issue microsoft/vscode-python#20274
Also mentioned here #11904

@DonJayamanne DonJayamanne added kernel-picker bug Issue identified by VS Code Team member as probable bug labels Nov 30, 2022
@DonJayamanne DonJayamanne added this to the December 2022 milestone Nov 30, 2022
@DonJayamanne DonJayamanne added the upstream-python Blocked on upstream Python Ext label Nov 30, 2022
@roblourens
Copy link
Member Author

I don't think this is related to the back button. esc cancels the whole flow, it doesn't go back

@DonJayamanne
Copy link
Contributor

we don't know what happened?
the create environment quick pick is from python, so we don't know whether you hit escacpe or the environmetn was not created or user hit back button.

@DonJayamanne
Copy link
Contributor

we need Python extension to tell us exactly what happened so we can make an informed decision on the workfow here

@rebornix rebornix added notebook-kernel Kernels issues (start/restart/switch/execution, install ipykernel) notebook-kernel-picker mru and removed kernel-picker labels Dec 9, 2022
@rebornix rebornix modified the milestones: February 2023, Backlog Feb 17, 2023
@DonJayamanne DonJayamanne added the verified Verification succeeded label Feb 27, 2023
@DonJayamanne DonJayamanne modified the milestones: Backlog, February 2023 Feb 27, 2023
@DonJayamanne
Copy link
Contributor

This had a test plan item and was verified

@DonJayamanne DonJayamanne reopened this May 15, 2023
@DonJayamanne DonJayamanne modified the milestones: February 2023, May 2023 May 15, 2023
@DonJayamanne DonJayamanne mentioned this issue May 15, 2023
Closed
@DonJayamanne
Copy link
Contributor

Fixed

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

@DonJayamanne DonJayamanne

Labels
bug Issue identified by VS Code Team member as probable bug notebook-kernel Kernels issues (start/restart/switch/execution, install ipykernel) notebook-kernel-picker upstream-python Blocked on upstream Python Ext verified Verification succeeded
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@roblourens @rebornix @DonJayamanne