"Create Environment"- pressing esc shows the kernel picker again

[DonJayamanne]

Regression #12240

Other steps to repro:

• Open kernel picker
• Select Python Environment
• Hit escape
• It will go back to the kernel source picker

@rebornix this is not working again, I noticed this some time ago, but forgot to file an issue or look into this.
Can confirm there's definitely a bug here now as this flow is not right, i can never escape the kernel picker, it always goes back to the Kernel Source Picker

[DonJayamanne]

@mjbvz this PR is what caused the regression
https://github.com/microsoft/vscode/pull/175603/files

There's no way for commands to throw exceptions now, VS Code seems to swallow them as a result of the above chaneg.

Upstream issue microsoft/vscode#182559

[DonJayamanne]

@rebornix is it possble to assume that the kernel picker is supposed to hide if no kernels are returned

					if (selectedKernelId) {
						const { all } = await this._getMatchingResult(notebook);
						const kernel = all.find(kernel => kernel.id === `ms-toolsai.jupyter/${selectedKernelId}`);
						if (kernel) {
							await this._selecteKernel(notebook, kernel);
							return true;
						}
						return true;
					} else {
						return this.displaySelectAnotherQuickPick(editor, false);
					}

I.e. why do we need the else clause here
Lets chat offline