Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ipywidgets 8 #8552

Closed
1 task
DonJayamanne opened this issue Dec 15, 2021 · 25 comments · Fixed by #12754
Closed
1 task

Add support for ipywidgets 8 #8552

DonJayamanne opened this issue Dec 15, 2021 · 25 comments · Fixed by #12754
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug ipywidgets Rendering, loading, saving, anything to do with IPyWidgets on-testplan

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Dec 15, 2021

Packages such as tqdm will not work with the latest version of IPyWidgets 8

Work around - Please install ipywidgets==7.7.2

@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug ipywidgets Rendering, loading, saving, anything to do with IPyWidgets labels Dec 15, 2021
@DonJayamanne DonJayamanne self-assigned this Dec 15, 2021
@DonJayamanne DonJayamanne changed the title Add sorry for ipywidgets 8 Add support for ipywidgets 8 Dec 15, 2021
@DonJayamanne DonJayamanne changed the title Add support for ipywidgets 8 Add (or prepare) support for ipywidgets 8 Dec 15, 2021
@rchiodo rchiodo added this to the January 2022 milestone Dec 16, 2021
@greazer greazer modified the milestones: February 2022, On Deck Feb 4, 2022
@JP-Ellis
Copy link

JP-Ellis commented Mar 8, 2022

Is this a difficult issue to resolve? Do we know what causes the widgets to not display at all?

@DonJayamanne
Copy link
Contributor Author

know what causes the widgets to not display at all?

we need to update the npm packages used and tweak a few places accordingly

@DonJayamanne DonJayamanne added the debt Code quality issues label Mar 8, 2022
@DonJayamanne DonJayamanne self-assigned this Mar 8, 2022
@JP-Ellis
Copy link

Is there a temporary workaround which might allow this to work while a permanent fix is being worked on?

@DonJayamanne
Copy link
Contributor Author

temporary workaround which might

unfortunately no. you can use the older version. i don't think 8 had been released yet.

@JP-Ellis
Copy link

All good! While version 8 is not yet marked as stable, it has been available on pypi as a pre-release since February 2020, and the first beta (?) appeared in November 2021. There's a few things I'm looking forward to use once it works well within VS Code 😄

@JP-Ellis
Copy link

Just as a friendly FYI: The first release candidate for 8.0.0 was released on 12 March.

@DonJayamanne
Copy link
Contributor Author

DonJayamanne commented Mar 30, 2022

@JP-Ellis please test the latest pre-release version of the extension, it should work as long as you are not using any of the latest IPyWidget 8.0 widgets/features. I.e. older widgets like slider/textboxes, etc and othe 3rd party widgets will now work when installing ipywidgets 8.0.

@JP-Ellis
Copy link

JP-Ellis commented Apr 1, 2022

Unfortunately it didn't seem to work for me. I tested the HTML and Dropdown widgets from ipywidgets v8.0.0rc0 and against v2022.4.1000912146 of the extension and nothing showed up. Let me know if there's anything specific you would like me to try or output you wish to see.

@DonJayamanne
Copy link
Contributor Author

DonJayamanne commented Apr 5, 2022

Will test, I tried this with the 8b1, not the rc version.
Confirmed, it widgets still do not render in IPYWidgets 8 (there must have been some protocol change in the RC version)

@DonJayamanne
Copy link
Contributor Author

@JP-Ellis
I've just tried this again against the latest pre-release and the v8.0.0rc0 and it seems to work for me
Here's the version of Jupyter extension installed v2022.4.1000971004, please could you let me know if this works?

@alex180500
Copy link

any update on this?

@giswqs

This comment was marked as resolved.

@basnijholt
Copy link

For the folks asking for updates, @kieferrm posted that "Support ipywidget 8 #8552 @DonJayamanne" is on the planning for February 🎉

This is great! I keep getting questions from colleagues about why their widgets aren't working in VS Code 😄

@matifali
Copy link

matifali commented Feb 10, 2023

Nice, so that it will work out of the box now? or we need to install update something?

@DonJayamanne
Copy link
Contributor Author

Please wait till early next week and it will work in a prerelease version

@DonJayamanne
Copy link
Contributor Author

@matifali you should be able to test this within an hour
Please install the pre-release version of the Jupyter extension and the latest version of the notebook renderer application in vscode insiders

@pcmoritz
Copy link

@DonJayamanne Do you know when we can expect the fix to this being available in a released version of this extension? That would be very much appreciated! Thanks for fixing this :)

@DonJayamanne
Copy link
Contributor Author

DonJayamanne commented Jun 16, 2023

We generally close issues when it’s been resolved
If not resolved and cleared then we add comments to that effect
The support for ipywidgets 8 was added a few releases ago

@pcmoritz
Copy link

Got it, thanks a lot! I think I got confused with the old version that was released on https://github.com/microsoft/vscode-jupyter/releases/tag/2022.09.120 -- it seems on the marketplace a newer version is available. Thanks for your help and sorry for the confusion :)

@pcmoritz
Copy link

pcmoritz commented Jun 16, 2023

It looks like this issue was tricky to fix, kudos for getting it solved!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug ipywidgets Rendering, loading, saving, anything to do with IPyWidgets on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.