Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against interruptions when creating a venv #12147

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

DonJayamanne
Copy link
Contributor

No description provided.

@DonJayamanne DonJayamanne marked this pull request as ready for review November 23, 2022 03:49
@DonJayamanne DonJayamanne mentioned this pull request Nov 23, 2022
54 tasks
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2022

Codecov Report

Merging #12147 (0bd86d2) into main (a95a92f) will increase coverage by 0%.
The diff coverage is 71%.

@@          Coverage Diff           @@
##            main   #12147   +/-   ##
======================================
  Coverage     70%      70%           
======================================
  Files        497      497           
  Lines      31234    31276   +42     
  Branches    4905     4907    +2     
======================================
+ Hits       21912    21987   +75     
+ Misses      7445     7402   -43     
- Partials    1877     1887   +10     
Impacted Files Coverage Δ
...tebooks/controllers/kernelSource/kernelSelector.ts 79% <0%> (+<1%) ⬆️
src/platform/interpreter/contracts.ts 100% <ø> (ø)
src/platform/api/pythonApi.ts 70% <58%> (-1%) ⬇️
...ks/controllers/pythonEnvKernelConnectionCreator.ts 63% <82%> (+6%) ⬆️
src/platform/common/cancellation.ts 76% <100%> (+10%) ⬆️
.../notebooks/debugger/debugLocationTrackerFactory.ts 96% <0%> (-4%) ⬇️
...tive-window/debugger/jupyter/kernelDebugAdapter.ts 60% <0%> (-2%) ⬇️
...otebooks/controllers/controllerPreferredService.ts 70% <0%> (-2%) ⬇️
src/kernels/helpers.ts 72% <0%> (-2%) ⬇️
.../notebooks/controllers/vscodeNotebookController.ts 84% <0%> (ø)
... and 8 more

// Else we might end up creating a controller for this event and that could get selected some other way (e.g. made preferred or other)
// E.g. if the user has previously used .venv for this notebook,. then as soon as this venv is created
// we'll end up creating a controller for this venv and that will get selected by vscode
interpreterService.pauseInterpreterDetection(cancellation.token);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

@DonJayamanne DonJayamanne merged commit 55ca7ac into main Nov 23, 2022
@DonJayamanne DonJayamanne deleted the pauseInterpreteDetection branch November 23, 2022 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants