Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation links for kernel sources #12614

Merged
merged 1 commit into from
Jan 23, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
NotebookDocument,
NotebookKernelSourceAction,
notebooks,
Uri,
window
} from 'vscode';
import { ContributedKernelFinderKind } from '../../../kernels/internalTypes';
Expand Down Expand Up @@ -67,6 +68,7 @@ export class KernelSourceCommandHandler implements IExtensionSyncActivationServi
return [
{
label: DataScience.localPythonEnvironments,
documentation: Uri.parse('https://aka.ms/vscodeJupyterExtKernelPickerPythonEnv'),
command: 'jupyter.kernel.selectLocalPythonEnvironment'
}
];
Expand All @@ -79,6 +81,7 @@ export class KernelSourceCommandHandler implements IExtensionSyncActivationServi
return [
{
label: DataScience.localPythonEnvironments,
documentation: Uri.parse('https://aka.ms/vscodeJupyterExtKernelPickerPythonEnv'),
command: 'jupyter.kernel.selectLocalPythonEnvironment'
}
];
Expand Down Expand Up @@ -116,6 +119,7 @@ export class KernelSourceCommandHandler implements IExtensionSyncActivationServi
kernelSpecActions = [
{
label: DataScience.localKernelSpecs,
documentation: Uri.parse('https://aka.ms/vscodeJupyterExtKernelPickerJupyterKernels'),
command: 'jupyter.kernel.selectLocalKernelSpec'
}
];
Expand Down Expand Up @@ -167,7 +171,12 @@ export class KernelSourceCommandHandler implements IExtensionSyncActivationServi
provideNotebookKernelSourceActions: () => {
return [
{
label: provider.displayName ?? provider.id,
label:
provider.displayName ??
(provider.detail ? `${provider.detail} (${provider.id})` : provider.id),
documentation: provider.id.startsWith('_builtin')
? Uri.parse('https://aka.ms/vscodeJuptyerExtKernelPickerExistingServer')
: undefined,
command: {
command: 'jupyter.kernel.selectJupyterServerKernel',
arguments: [provider.id],
Expand All @@ -184,6 +193,9 @@ export class KernelSourceCommandHandler implements IExtensionSyncActivationServi
label:
provider.displayName ??
(provider.detail ? `${provider.detail} (${provider.id})` : provider.id),
documentation: provider.id.startsWith('_builtin')
? Uri.parse('https://aka.ms/vscodeJuptyerExtKernelPickerExistingServer')
: undefined,
command: {
command: 'jupyter.kernel.selectJupyterServerKernel',
arguments: [provider.id],
Expand Down