Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notebookUri/tab.uri comparison to handle leading slash differences #13019

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

debonte
Copy link
Contributor

@debonte debonte commented Mar 7, 2023

Fixes #13018

Fixed bug in _getNotebookUriForTextDocumentUri logic to handle VS Code adding a / at the start of notebook URI paths. This was probably what was originally intended rather than checking endsWith on the whole URI.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

@debonte debonte merged commit ba7fb3b into microsoft:main Mar 7, 2023
@debonte debonte deleted the pylance3941 branch March 7, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UndefinedVariable in interactive window
3 participants