Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use path.sep instead of \\ when translating IW input box URI to notebook URI #13269

Merged
merged 9 commits into from
Apr 6, 2023
Merged

Use path.sep instead of \\ when translating IW input box URI to notebook URI #13269

merged 9 commits into from
Apr 6, 2023

Conversation

debonte
Copy link
Contributor

@debonte debonte commented Apr 4, 2023 •
edited
Loading

Fixes #13018

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@debonte debonte requested a review from amunger April 4, 2023 21:28
amunger
amunger previously approved these changes Apr 5, 2023
View reviewed changes
amunger
amunger previously approved these changes Apr 5, 2023
View reviewed changes
@debonte debonte merged commit cdc9c72 into microsoft:main Apr 6, 2023
@debonte debonte deleted the jupyter13018 branch April 6, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amunger amunger amunger approved these changes

Assignees

@debonte debonte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UndefinedVariable in interactive window
2 participants
@debonte @amunger