Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to add reviewers to Pull Request in PR Description View #1181

Closed
GeorgeWL opened this issue May 29, 2019 · 4 comments
Closed

Unable to add reviewers to Pull Request in PR Description View #1181

GeorgeWL opened this issue May 29, 2019 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@GeorgeWL
Copy link

Issue Type: Bug

Steps to Reproduce:

  1. Attempt to add Reviewers to a Private Repo Pull Request by pressing the plus symbol in the pull request
  2. Action doesn't happen, notification of
Cannot read property 'filter' of undefined
Source: Github Pull Requests (Extension)

On inspection with Developer Console of VSCode, the error comes from:

onDidNotificationChange(e) {
     0 === e.kind && (this.triggerAriaAlert(e.item),
    e.item.severity === r.Severity.Error && (e.item.message.original instanceof Error ? console.error(e.item.message.original) : console.error(o.toErrorMessage(e.item.message.value, !0))))
}

Extension version: 0.7.0
VS Code version: Code 1.34.0 (a622c65b2c713c890fcf4fbf07cf34049d5fe758, 2019-05-15T21:59:37.030Z)
OS version: Windows_NT x64 10.0.17763

System Info
Item Value
CPUs Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 x 2592)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 31.74GB (16.84GB free)
Process Argv --folder-uri file:///c%3A/Users/george/dev/lender-admin
Screen Reader no
VM 0%
@meaghanlewis meaghanlewis added the bug Issue identified by VS Code Team member as probable bug label May 29, 2019
@StanleyGoldman StanleyGoldman added the help wanted Issues identified as good community contribution opportunities label Jun 1, 2019
@curtisgibby
Copy link
Contributor

A bit of additional info: the first time or two I attempted to use this functionality, it worked as expected, giving me a checklist of possible reviewers. Now, every time, I get the error message described above.

@RMacfarlane RMacfarlane removed the help wanted Issues identified as good community contribution opportunities label Jul 12, 2019
@RMacfarlane RMacfarlane self-assigned this Jul 12, 2019
@GeorgeWL
Copy link
Author

@RMacfarlane why has this been closed? I don't see a fix in the PRs.

@RMacfarlane
Copy link
Contributor

@GeorgeWL I closed this in commit 5479c4e. A version with the fix hasn’t been released yet

@GeorgeWL
Copy link
Author

ah was confused, the usual process I've seen the devs do on this repo was to close with a comment of something like resolved in 5479c4e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

5 participants