Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments get disposed from file that has both recent and outdated comments #1279

Closed
RMacfarlane opened this issue Jul 22, 2019 · 0 comments · Fixed by #1280
Closed

Comments get disposed from file that has both recent and outdated comments #1279

RMacfarlane opened this issue Jul 22, 2019 · 0 comments · Fixed by #1280
Assignees
@RMacfarlane
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@RMacfarlane
Copy link
Contributor

  1. Check out a PR that has both recent comments and outdated comments on the same file
  2. Open that file from the “Changes in Pull Request” tree
  3. Wait for update polling to kick in, about 30 seconds

Comments are deleted from the file.
@RMacfarlane RMacfarlane added the bug Issue identified by VS Code Team member as probable bug label Jul 22, 2019
@RMacfarlane RMacfarlane self-assigned this Jul 22, 2019
@RMacfarlane RMacfarlane mentioned this issue Jul 22, 2019
Merged
RMacfarlane pushed a commit that referenced this issue Jul 22, 2019
Fix updates to outdated comments, fixes #1279
0bc1814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RMacfarlane RMacfarlane

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix updates to outdated comments microsoft/vscode-pull-request-github
1 participant
@RMacfarlane