Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot create a PR if source branch is not included in remotes settings #1326

Closed
sbatten opened this issue Sep 4, 2019 · 1 comment
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@sbatten
Copy link
Member

sbatten commented Sep 4, 2019

  1. Create a typical setup where you have an upstream remote and your fork remote added in your local repo.
  2. Rename them. E.g. microsoft and sbatten respectively.
  3. Use the githubPullRequests.remotes setting to add just microsoft as that's the only remote I care about PRs for.
  4. Try to create a PR where the source branch is from the fork sbatten in my case.

🐛 => this silently fails. Console logs show that it does not believe the fork is a github repo.

@RMacfarlane
Copy link
Contributor

Pushed a change to at least show a notification in this case with an option to configure remotes

@RMacfarlane RMacfarlane added the bug Issue identified by VS Code Team member as probable bug label Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

3 participants