Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request Changes and Approve should be next to Comment #297

Closed
Tyriar opened this issue Aug 28, 2018 · 1 comment
Closed

Request Changes and Approve should be next to Comment #297

Tyriar opened this issue Aug 28, 2018 · 1 comment
Labels
good first issue Good for newcomers ux

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 28, 2018 •
edited
Loading

microsoft/vscode#57301

screen shot 2018-08-28 at 11 14 24 am

screen shot 2018-08-28 at 11 14 29 am
@Tyriar
Copy link
Member Author

Tyriar commented Aug 28, 2018

Doh, it's on the other side. In that case Request Changes and Approve should be on the other side as they're related, Close is very different (and more destructive).

@Tyriar Tyriar changed the title Missing submit "Comment" feedback option Request Changes and Approve should be next to Comment Aug 28, 2018
@rebornix rebornix added the ux label Aug 28, 2018
@RMacfarlane RMacfarlane added the good first issue Good for newcomers label Jul 9, 2019
@guilherme-gm guilherme-gm mentioned this issue Oct 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers ux
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rebornix @Tyriar @RMacfarlane