Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments disappearing after exiting review mode #3173

Closed
alexr00 opened this issue Dec 9, 2021 · 0 comments
Closed

Comments disappearing after exiting review mode #3173

alexr00 opened this issue Dec 9, 2021 · 0 comments
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Milestone
November 2021 Rec...

Comments

@alexr00
Copy link
Member

alexr00 commented Dec 9, 2021 •
edited
Loading

  1. Checkout a PR that has comments in some files.
  2. Open a file with comments and see the comments
  3. Checkout the default branch
  4. Open a diff from the same PR in the PRs view
  5. 🐛 no comments.
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Dec 9, 2021
@alexr00 alexr00 added this to the November 2021 Recovery milestone Dec 9, 2021
@alexr00 alexr00 self-assigned this Dec 9, 2021
@alexr00 alexr00 added the candidate Issue identified as probable candidate for fixing in the next release label Dec 9, 2021
alexr00 added a commit that referenced this issue Dec 9, 2021
@alexr00
Fix repositories getting disposed
01eb079 
Part of #3173
alexr00 added a commit that referenced this issue Dec 9, 2021
@alexr00
Fix repositories getting disposed
f077535 
Part of #3173
@alexr00 alexr00 mentioned this issue Dec 9, 2021
Merged
alexr00 added a commit that referenced this issue Dec 13, 2021
@alexr00
Fix repositories getting disposed (#3174)
218d85b 
Part of #3173
@alexr00 alexr00 closed this as completed Dec 13, 2021
@alexr00 alexr00 added the verified Verification succeeded label Dec 13, 2021
@alexr00 alexr00 mentioned this issue Dec 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Projects
None yet
Milestone
November 2021 Recovery
Development

No branches or pull requests
1 participant
@alexr00