Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many spurious user mentions inserted in text #3257

Closed
pokey opened this issue Jan 18, 2022 · 4 comments · Fixed by #3261
Closed

Many spurious user mentions inserted in text #3257

pokey opened this issue Jan 18, 2022 · 4 comments · Fixed by #3261
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@pokey
Copy link

pokey commented Jan 18, 2022

Issue Type: Bug

When editing a new GitHub issue from within VSCode, I'll get lots of spurious insertions of user names as I type, meaning I'm often cleaning up after this extension. Here is an example:

ezgif com-gif-maker

Notice how I'm just typing normally, no @ or <tab>, but a random name comes out of nowhere. In case helpful, I did it again, this time slowing down long enough for the pop-up to appear:

ezgif com-gif-maker (1)

I believe the issue is that the suggestions are quite lenient, and hitting <space> accepts the completion. A couple solutions I could think of:

  • Only make suggestions if the token starts with @ (or if not desired to have this be default behaviour, at least adding a setting where I can force this)
  • Have a setting to disable <space> to accept suggestion

Extension version: 0.34.3
VS Code version: Code 1.63.2 (899d46d82c4c95423fb7e10e68eba52050e30ba3, 2021-12-15T09:37:28.172Z)
OS version: Darwin x64 21.2.0
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz (16 x 2300)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 32.00GB (0.02GB free)
Process Argv --crash-reporter-id 99d35f96-61a9-461b-a60d-f915d32f3eee
Screen Reader no
VM 0%
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscorecescf:30384386
pythondataviewer:30285071
vscod805:30301674
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
vscop804cf:30404767
vscop453:30404998
vsrem710cf:30416617
vsccppwtstudy:30421978

@alexr00
Copy link
Member

alexr00 commented Jan 18, 2022

Do you have the setting "editor.quickSuggestions": true?

@alexr00 alexr00 added the info-needed Issue requires more information from poster label Jan 18, 2022
@pokey
Copy link
Author

pokey commented Jan 18, 2022

Do you have the setting "editor.quickSuggestions": true?

It appears that I do:

    "editor.quickSuggestions": {
        "other": true,
        "comments": true,
        "strings": true
    },

I believe I turned them on at the advice of the All Autocomplete extension fwiw

@alexr00 alexr00 self-assigned this Jan 18, 2022
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Jan 18, 2022
@alexr00 alexr00 added this to the January 2022 milestone Jan 18, 2022
alexr00 added a commit that referenced this issue Jan 19, 2022
@alexr00
Copy link
Member

alexr00 commented Jan 19, 2022

I've pushed a change that will only include users in the quick suggest when on the Assignees line of the new issue file.

@pokey
Copy link
Author

pokey commented Jan 19, 2022

Ah right yeah that seems like a nice fix thank you!

@mjbvz mjbvz added the verified Verification succeeded label Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants