Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"viewed" checkboxes don't always propagate #3959

Closed
alexr00 opened this issue Sep 19, 2022 · 2 comments · Fixed by #3976 or #4019
Closed

"viewed" checkboxes don't always propagate #3959

alexr00 opened this issue Sep 19, 2022 · 2 comments · Fixed by #3976 or #4019
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@alexr00
Copy link
Member

alexr00 commented Sep 19, 2022

  1. Check out a PR and mark all the files in a folder as read.
  2. Reload.
  3. Expected: The parent folder of the files you marked as viewed will be checked.
    Actual: All the children are checked, but the parent is not.
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Sep 19, 2022
@alexr00 alexr00 added this to the September 2022 milestone Sep 19, 2022
@alexr00 alexr00 changed the title "viewed" checkboxes don't propagate up if they're check when the PR is opened "viewed" checkboxes don't always propagate Sep 22, 2022
@alexr00
Copy link
Member Author

alexr00 commented Sep 22, 2022

Found the actual problem. Real repro steps:

  1. Open a PR that has folders that get collapsed onto one line. Example (see that folder2 is nested under folder1 but they get shown on one line):
    image
  2. Mark all the files in the folders as viewed
  3. See that the check doesn't get propagated to the parent folder.

@roblourens
Copy link
Member

Most of these select the parent folder when all the children are selected, except for the top level

Recording 2022-09-30 at 13 21 14

@roblourens roblourens reopened this Sep 30, 2022
@roblourens roblourens added the verification-found Issue verification failed label Sep 30, 2022
@alexr00 alexr00 modified the milestones: September 2022, October 2022 Oct 3, 2022
alexr00 added a commit that referenced this issue Oct 5, 2022
Fix for directory checkboxes.
Fixes #3959
alexr00 added a commit that referenced this issue Oct 5, 2022
Fix for directory checkboxes.
Fixes #3959
@alexr00 alexr00 removed the verification-found Issue verification failed label Oct 26, 2022
@andreamah andreamah added the verified Verification succeeded label Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
4 participants