Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension periodically refreshes the file under review, resetting the view position #4031

Closed
RikkiGibson opened this issue Oct 10, 2022 · 7 comments · Fixed by #4034
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@RikkiGibson
Copy link
Member

RikkiGibson commented Oct 10, 2022

Description

  1. Install both GitHub Pull Requests (v0.50.0) and https://marketplace.visualstudio.com/items?itemName=eamodio.gitlens (v12.2.2).
  2. Open a pull request in the extension and begin reviewing a file
  3. Proceed with review for about 1-2 minutes

Expected behavior: editor view position is only affected by user actions (e.g. navigation commands, scrolling)
Actual behavior: editor view position is periodically reset, disrupting the review.

Note that this behavior only occurs when both the GitLens and GitHub extensions are enabled. When I disable the GitLens extension, the bad behavior stops. I am not sure which extension is to "blame" in this scenario, so I'm taking the liberty of filing a bug both here and at gitkraken/vscode-gitlens#2259.

VS Code Version

Version: 1.72.0 (user setup)
Commit: 64bbfbf67ada9953918d72e1df2f4d8e537d340e
Date: 2022-10-04T23:20:39.912Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Windows_NT x64 10.0.19044
Sandboxed: No

Git Version

git version 2.30.0.windows.2

Logs, Screenshots, Screen Captures, etc

This recording roughly shows the bad behavior, which occurs once every 1-2 minutes. Note that several different activity indicators are popping up in the left sidebar before the editor tab goes blank and refreshes.
ghpri-refresh-bug-3

@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Oct 10, 2022
@alexr00 alexr00 self-assigned this Oct 10, 2022
@alexr00 alexr00 added this to the October 2022 milestone Oct 10, 2022
@alexr00
Copy link
Member

alexr00 commented Oct 10, 2022

I haven't yet been able to reproduce this issue. I'll keep an eye out for it.

@alexr00 alexr00 modified the milestones: October 2022, On Deck Oct 10, 2022
@alexr00
Copy link
Member

alexr00 commented Oct 10, 2022

And now I was just able to repro it.

@eamodio
Copy link
Contributor

eamodio commented Oct 12, 2022

@alexr00 is this a GHPR issue?

@alexr00
Copy link
Member

alexr00 commented Oct 12, 2022

@eamodio I found a GHPR issue that caused it. I don't know why the issue would only repro with Gitlens. I would assume that was a fluke as it didn't occur 100% of the time for me.

@eamodio
Copy link
Contributor

eamodio commented Oct 12, 2022

Awesome thank you!

@joyceerhl joyceerhl added the verified Verification succeeded label Oct 26, 2022
@jpspringall
Copy link
Contributor

Do you we know when this fix is going available in the insiders build?

As it also appears reset comments, which is a bit of a PITA :-)

@alexr00
Copy link
Member

alexr00 commented Oct 27, 2022

@jpspringall the fix has been in the pre-release build of the extension (which requires that you use VS Code Insiders) for about 2 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
5 participants