Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does the GHPRI extension need to be * activated? #4046

Closed
joyceerhl opened this issue Oct 12, 2022 · 0 comments · Fixed by #4094
Closed

Does the GHPRI extension need to be * activated? #4046

joyceerhl opened this issue Oct 12, 2022 · 0 comments · Fixed by #4094
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
October 2022

Comments

@joyceerhl
Copy link
Contributor

joyceerhl commented Oct 12, 2022 •
edited
Loading

It looks like this came in via #2522. It used to be activated onStartupFinished.

IMO the GHPRI extension should only activate (at least in web) when the user

  • Is currently on a PR
  • Focuses one of GHPRI's views
  • Runs one of GHPRI's commands

To achieve this we also need RemoteHub to not force-activate GHPRI unless the user is on a PR.
This was referenced Oct 13, 2022
Closed
Closed
@alexr00 alexr00 added this to the October 2022 milestone Oct 18, 2022
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Oct 18, 2022
alexr00 added a commit that referenced this issue Oct 20, 2022
@alexr00
Does the GHPRI extension need to be * activated?
75e7a71 
Fixes #4046
@alexr00 alexr00 mentioned this issue Oct 20, 2022
Merged
alexr00 added a commit that referenced this issue Oct 20, 2022
@alexr00
Does the GHPRI extension need to be * activated? (#4094)
918d0da 
Fixes #4046
@joyceerhl joyceerhl added the verified Verification succeeded label Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
October 2022
Development

Successfully merging a pull request may close this issue.

Does the GHPRI extension need to be * activated? microsoft/vscode-pull-request-github
2 participants
@joyceerhl @alexr00