Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No Longer Prompted To Create PR after Pushing Feature Branch #4171

Closed
conradwt opened this issue Nov 9, 2022 · 3 comments
Closed

No Longer Prompted To Create PR after Pushing Feature Branch #4171

conradwt opened this issue Nov 9, 2022 · 3 comments
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded

Comments

@conradwt
Copy link

conradwt commented Nov 9, 2022 •
edited
Loading

No Longer Prompted To Create PR after Pushing Feature Branch

  • Extension version: v0.55.2022110809
  • VSCode Version: 1.74.0-insider (Universal)
  • OS: macOS 12.6

Steps to Reproduce:

  1. Create Feature Branch
  2. add and commit one or more files via VSCode-Insiders UI
  3. git push via VSCode-Insiders UI
  4. Not prompted to create PR
@alexr00 alexr00 self-assigned this Nov 10, 2022
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Nov 10, 2022
@alexr00 alexr00 added this to the November 2022 milestone Nov 10, 2022
@alexr00 alexr00 added the candidate Issue identified as probable candidate for fixing in the next release label Nov 11, 2022
@alexr00 alexr00 modified the milestones: November 2022, October 2022 Recovery Nov 11, 2022
@alexr00 alexr00 mentioned this issue Nov 11, 2022
Merged
alexr00 added a commit that referenced this issue Nov 11, 2022
@alexr00
No Longer Prompted To Create PR after Pushing Feature Branch
1a0e4d4 
Part of #4171
alexr00 added a commit that referenced this issue Nov 11, 2022
@alexr00
No Longer Prompted To Create PR after Pushing Feature Branch
98a131d 
Part of #4171
@alexr00 alexr00 mentioned this issue Nov 11, 2022
Merged
alexr00 added a commit that referenced this issue Nov 11, 2022
@alexr00
No Longer Prompted To Create PR after Pushing Feature Branch (#4180)
ee9bb66 
Part of #4171
alexr00 added a commit that referenced this issue Nov 16, 2022
@alexr00
No Longer Prompted To Create PR after Pushing Feature Branch (#4181)
6a72ee5 
Part of #4171
@alexr00 alexr00 closed this as completed Nov 16, 2022
@alexr00
Copy link
Member

alexr00 commented Nov 16, 2022

To verify:

  1. Make sure you have "githubPullRequests.createOnPublishBranch": "ask"
  2. Open a GitHub repo in VS Code
  3. Create a topic branch
  4. Run the Git: Publish Branch... command
  5. Verify that you see a notification to create a pull request.

@dbaeumer
Copy link
Member

Verified.

@dbaeumer dbaeumer added the verified Verification succeeded label Nov 16, 2022
@conradwt
Copy link
Author

@alexr00 Yes, I have had this option set forever.

Screen Shot 2022-11-16 at 4 24 40 PM

eslamashour1 pushed a commit to eslamashour1/vscode-pull-request-github that referenced this issue Dec 31, 2022
@alexr00 @eslamashour1
No Longer Prompted To Create PR after Pushing Feature Branch (microso…
0b2014b 
…ft#4180)

Part of microsoft#4171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@conradwt @dbaeumer @alexr00