Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing a label with another appears to work in vscode but doesn't #4492

Closed
MagsMagnoli opened this issue Feb 3, 2023 · 0 comments
Closed

Replacing a label with another appears to work in vscode but doesn't #4492

MagsMagnoli opened this issue Feb 3, 2023 · 0 comments
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Milestone
January 2023 Reco...

Comments

@MagsMagnoli
Copy link

  • Extension version: v0.58.0
  • VSCode Version: 1.75.0
  • OS: macOS Ventura 13.2

Steps to Reproduce:

  1. Create a PR with a label
  2. Click the settings button to display the label dialog
  3. Deselect the current label and select another
  4. Observe vscode appears to have replaced the label as expected
  5. Observe github now shows both labels

Screenshots

Vscode PR with two labels:
Screenshot 2023-02-03 at 10 07 12
Replacing both labels with another via modal in Vscode:
Screenshot 2023-02-03 at 10 07 35
Vscode appears correct:
Screenshot 2023-02-03 at 10 07 42
GitHub now shows all 3 labels:
Screenshot 2023-02-03 at 10 07 47
@alexr00 alexr00 self-assigned this Feb 3, 2023
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release labels Feb 3, 2023
@alexr00 alexr00 added this to the January 2023 Recovery milestone Feb 3, 2023
@alexr00 alexr00 mentioned this issue Feb 3, 2023
Merged
alexr00 added a commit that referenced this issue Feb 3, 2023
@alexr00
Replacing a label with another appears to work in vscode but doesn't
a42e9f6 
Part of #4492
alexr00 added a commit that referenced this issue Feb 3, 2023
@alexr00
Replacing a label with another appears to work in vscode but doesn't
23b5ea6 
Part of #4492
@alexr00 alexr00 mentioned this issue Feb 3, 2023
Merged
alexr00 added a commit that referenced this issue Feb 3, 2023
@alexr00
Replacing a label with another appears to work in vscode but doesn't (#…
ad954b5 
…4495)

Part of #4492
alexr00 added a commit that referenced this issue Feb 6, 2023
@alexr00
Replacing a label with another appears to work in vscode but doesn't (#…
052ab00 
…4496)

Part of #4492
@alexr00 alexr00 closed this as completed Feb 7, 2023
@roblourens roblourens added the verified Verification succeeded label Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Projects
None yet
Milestone
January 2023 Recovery 1
Development

No branches or pull requests
3 participants
@roblourens @MagsMagnoli @alexr00