Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted PR remains visible in "Local Pull Request Branches" tab of sidebar #4855

Closed
curtdrummondvpc opened this issue May 25, 2023 · 4 comments · Fixed by #4884
Closed

Reverted PR remains visible in "Local Pull Request Branches" tab of sidebar #4855

curtdrummondvpc opened this issue May 25, 2023 · 4 comments · Fixed by #4884
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@curtdrummondvpc
Copy link

curtdrummondvpc commented May 25, 2023

  • Extension version: v0.65.2023051809
  • VSCode Version: v1.78.2
  • OS: Mac OSX 13.3.1 (a)

Steps to Reproduce:

Unclear how to reproduce this, but there's a PR that was reverted a long time ago that remains visible in the "Local Pull Request Branches" section of the extension's sidebar.

  1. Open VSCode
  2. Open Github Pull Requests and Issues extension sidebar
  3. Pull request is visible even though it was closed and then reverted.

See screenshot for the PR that won't go away, as well as a section of settings.json where I have tried to follow other advice found (e.g. #4809) to try to ignore this PR.

Screenshot 2023-05-25 at 1 29 15 PM

@BrotherErryn
Copy link

I'm having this same issue with one that was merged. It has no outstanding reviews/etc. and I have verified that it is indeed merged. It was a release merge into main from development, if that makes any difference. Have attempted the same settings @curtdrummondvpc indicated above, but no change.

I could ignore this pretty easily if it didn't pop up a notice reminding me it was there every time I switched back into the development branch.

@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label May 31, 2023
@alexr00 alexr00 self-assigned this May 31, 2023
@alexr00 alexr00 added this to the June 2023 milestone May 31, 2023
@alexr00
Copy link
Member

alexr00 commented Jun 2, 2023

@BrotherErryn there should be a "Don't show again" on the notification that you're seeing.

@alexr00
Copy link
Member

alexr00 commented Jun 2, 2023

The new behavior will be to respect the useReviewMode setting for PRs in the Local Pull Request Branches list.

@roblourens roblourens added the verified Verification succeeded label Jun 28, 2023
@roblourens
Copy link
Member

"reverted" just means "closed" here? If so, looks good to me now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
4 participants