Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot review PRs with 0.78.0 / VSCode 1.85.0, "GraphQL error: Field 'mergeQueueEntry' doesn't exist #5544

Closed
janakjjp opened this issue Dec 11, 2023 · 10 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded

Comments

@janakjjp
Copy link

janakjjp commented Dec 11, 2023

  • Extension version: 0.78.0
  • VSCode Version: 1.85.0
  • OS: macOS Sonoma 14.1.2
  • Repository Clone Configuration (single repository/fork of an upstream repository): N/A (doing pull requests on a single repo)
  • Github Product (Github.com/Github Enterprise version x.x.x): GHE 3.7.0 (on-prem)

Steps to Reproduce:

  1. Update the extension and VSCode to the aforementioned versions
  2. Go to the Pull Request view
  3. Receive the error Fetching pull requests failed: GraphQL error: Field 'mergeQueueEntry' doesn't exist on type 'PullRequest' GraphQL error: No such type MergeQueueEntry, so it can't be a fragment condition
  4. I do not see listed under "Waiting For My Review."

(Is this a dependency on a newer version of GitHub/GHE?)

@janakjjp
Copy link
Author

Reverting to v0.76.1 fixes the issue.

@janakjjp
Copy link
Author

My settings.json shows, for the queries section:

  "githubPullRequests.queries": [
    {
      "label": "Waiting For My Review",
      "query": "is:open user-review-requested:${user}"
    },
    {
      "label": "Waiting For Team Review",
      "query": "is:open review-requested:${user} draft:false"
    },
    {
      "label": "Assigned To Me",
      "query": "is:open assignee:${user}"
    },
    {
      "label": "Created By Me",
      "query": "is:open author:${user}"
    }
  ],

@alexr00
Copy link
Member

alexr00 commented Dec 12, 2023

Yes, looks like this isn't available in your version of GHE.

@alexr00 alexr00 self-assigned this Dec 12, 2023
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release labels Dec 12, 2023
@alexr00 alexr00 modified the milestones: December / January 2024, November 2023 Recovery 1 Dec 12, 2023
alexr00 added a commit that referenced this issue Dec 13, 2023
@alexr00
Copy link
Member

alexr00 commented Dec 13, 2023

@janakjjp I'm not able to reproduce this issue. I've made a possible fix and it is available in the pre-release build. Would you be able to try out the latest pre-release build and see if the issue still occurs there.

@alexr00 alexr00 modified the milestones: November 2023 Recovery 1, December / January 2024 Dec 13, 2023
@alexr00 alexr00 added candidate Issue identified as probable candidate for fixing in the next release and removed candidate Issue identified as probable candidate for fixing in the next release labels Dec 13, 2023
@alexr00 alexr00 modified the milestones: December / January 2024, November 2023 Recovery 1, November 2023 Recovery 2 Dec 13, 2023
@joaomoreno joaomoreno removed this from the November 2023 Recovery 2 milestone Dec 13, 2023
@janakjjp
Copy link
Author

@janakjjp I'm not able to reproduce this issue. I've made a possible fix and it is available in the pre-release build. Would you be able to try out the latest pre-release build and see if the issue still occurs there.

I can confirm the newest pre-release works!

@alexr00
Copy link
Member

alexr00 commented Dec 13, 2023

@janakjjp that's great news! Thank you for trying it out. I will include the fix in the recovery release this week.

@theredpea
Copy link

theredpea commented Jan 12, 2024

Nice, thanks, using pre-release version fixes for me too! (on Windows 11)
For those who didn't know how to switch to pre-release (see screenshot below)

  • Open your VS Code extensions panel; find the VSCode Pull Request extension listed therein
  • Click on the gear/settings icon to open menu
  • In menu choose "Switch to Pre-Release Version"
    image

@maicss
Copy link

maicss commented Mar 7, 2024

GitHub Enterprise Server 3.9.10

image

Sign in only one github enterprise account.

@alexr00
Copy link
Member

alexr00 commented Mar 20, 2024

I'm not able to reproduce this. Are you somehow also signed in with a non-enterprise GH account?

@maicss
Copy link

maicss commented Mar 21, 2024

I'm not able to reproduce this. Are you somehow also signed in with a non-enterprise GH account?

Sorry, I cannot reproduce this too, because two weeks passed by, and I have tried again, it works fine. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants