Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Remove redundant prefix-style info from PR change view #5705

Closed
Tracked by #5778
jooyoungseo opened this issue Jan 31, 2024 · 3 comments · Fixed by #5711
Closed
Tracked by #5778

[Accessibility] Remove redundant prefix-style info from PR change view #5705

jooyoungseo opened this issue Jan 31, 2024 · 3 comments · Fixed by #5711
Assignees
Labels
accessibility bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@jooyoungseo
Copy link

jooyoungseo commented Jan 31, 2024

Type: Bug

@meganrogge

When prStatus:github.focus is triggered, screen reader users can navigate changed files in the treeview.

However, we have to listen to all the redundant prefix-type instruction before target file name like below:

View diffs and comments for file codeEditorWidget.ts

This means we have to digest this redundant info each time we arrow-down every single file. If there are multiple changed files, it gets even worse and tedious.

I think "View diffs and comments for file"instruction is redundant because users already know they are in the changed treeview. Please consider taking this out. Or, please turn off this info when accessibility.verbosity.diffEditor setting value is false.

image

Extension version: 0.79.2024013010
VS Code version: Code - Insiders 1.86.0-insider (05047486b6df5eb8d44b2ecd70ea3bdf775fd937, 2024-01-31T03:29:50.526Z)
OS version: Windows_NT x64 10.0.22631
Modes: Restricted
Connection to 'ssh-remote+7b22686f73744e616d65223a2244656c7461227d' could not be established

System Info
Item Value
CPUs 11th Gen Intel(R) Core(TM) i5-1145G7 @ 2.60GHz (8 x 2611)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) undefined
Memory (System) 15.71GB (6.18GB free)
Process Argv --crash-reporter-id b05b88e5-8894-4031-ae34-fa034ebddea9
Screen Reader yes
VM 0%

Connection to 'ssh-remote+7b22686f73744e616d65223a2244656c7461227d' could not be established

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
vscod805cf:30301675
vsaa593:30376534
py29gd2263:30784851
c4g48928:30535728
a9j8j154:30646983
962ge761:30841072
pythongtdpath:30726887
welcomedialog:30812478
pythonidxpt:30768918
pythonnoceb:30776497
asynctok:30898717
dsvsc013:30777762
dsvsc014:30777825
dsvsc015:30821418
pythontestfixt:30866404
pythonregdiag2:30926734
pyreplss1:30879911
pythonmypyd1:30859725
pythoncet0:30859736
pythontbext0:30879054
accentitlementst:30870582
dsvsc016:30879898
dsvsc017:30880771
dsvsc018:30880772
8082a590:30953407
edj9j583:30943796
fegfb526:30952798
7j2b6412:30951517
e3gdj431:30946825
ccp2r3:30950906

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug accessibility labels Jan 31, 2024
@meganrogge meganrogge added this to the March 2024 milestone Jan 31, 2024
@alexr00
Copy link
Member

alexr00 commented Feb 1, 2024

@jooyoungseo and @meganrogge what if we changed it to this:

codeEditorWidget.ts pull request diff

I don't really feel that the accessibility.verbosity.diffEditor setting really applies here, and I'd prefer not to introduce a new PR setting if possible.

@alexr00 alexr00 modified the milestones: March 2024, February 2024 Feb 1, 2024
@jooyoungseo
Copy link
Author

@alexr00 Moving the prefix instruction to the suffix also makes sense! Screen reader users can quickly jump to the next file after the file name is announced if they don't want to hear the remaining instruction.

@alexr00
Copy link
Member

alexr00 commented Feb 2, 2024

Great, that's what I'll do then. Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants