Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff Comment with HEAD button in Comments view sometimes disappears #6157

Closed
jo-mpac opened this issue Aug 23, 2024 · 4 comments · Fixed by #6197
Closed

Diff Comment with HEAD button in Comments view sometimes disappears #6157

jo-mpac opened this issue Aug 23, 2024 · 4 comments · Fixed by #6197
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug verified Verification succeeded

Comments

@jo-mpac
Copy link

jo-mpac commented Aug 23, 2024

  • Extension version:
    v0.94.0
  • VSCode Version:
    Version: 1.92.2 (Universal)
    Commit: fee1edb8d6d72a0ddff41e5f71a671c23ed924b9
    Date: 2024-08-14T17:29:30.058Z
    Electron: 30.1.2
    ElectronBuildId: 9870757
    Chromium: 124.0.6367.243
    Node.js: 20.14.0
    V8: 12.4.254.20-electron.0
    OS: Darwin arm64 23.6.0

Steps to Reproduce:

When a review comment is outdated, Diff Comment with HEAD button will show up and let me quickly check what are the changes that made this comment outdated.

However I noticed sometimes the button is gone, and I have to checkout to main and then back to the PR to get it appear again.

I believe there are multiple triggers for this, and refreshing the PR (like the attached video shows) is the most consistent trigger I found. However, when I tried to clone this repo(microsoft/vscode-pull-request-github) and recreate the exact scenario for reporting this issue, it didn't happen in my newly forked repo. That's why I couldn't provide reliable reproducing steps here and as a workaround I am attaching a screen recording to show the issue that is only happening in my repo:

Screen.Recording.2024-08-23.at.12.06.05.mov

I am a bit lost now and not sure how I should further debug this issue. I rely on this awesome feature a lot, so please let me know about anything else I can do to help debug this issue. Thanks a lot!

@alexr00 alexr00 self-assigned this Aug 30, 2024
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Aug 30, 2024
@alexr00 alexr00 added this to the September 2024 milestone Aug 30, 2024
@alexr00
Copy link
Member

alexr00 commented Aug 30, 2024

I also can't repro it, but I can see where this could happen.

@jo-mpac
Copy link
Author

jo-mpac commented Aug 30, 2024

I also can't repro it, but I can see where this could happen.

Thank you for looking into it. Please kindly let me know if you would like me to test out the fix.

@TylerLeonhardt
Copy link
Member

@jo-mpac can you try the latest pre-release version of the GitHub Pull Request? You can get it in the Extension Marketplace

@TylerLeonhardt TylerLeonhardt added the author-verification-requested Issues potentially verifiable by issue author label Sep 26, 2024
@jo-mpac
Copy link
Author

jo-mpac commented Sep 26, 2024

@jo-mpac can you try the latest pre-release version of the GitHub Pull Request? You can get it in the Extension Marketplace

Hey I have been using the pre-release for a while and I believe the issue was fixed! Thank you very much folks ❤️

@eleanorjboyd eleanorjboyd added the verified Verification succeeded label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
4 participants